Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6811/fc74f9a4 backport][stable-6] [datadog_downtime] - added 'type' to recurrence object when rrule param is present #6890

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jul 8, 2023

This is a backport of PR #6811 as merged into main (fc74f9a).

SUMMARY

The datadog_downtime module includes the optional rrule parameter to provide the recurrence for a downtime in the rrule-format. The datadog api client that the module is based on requires that the recurrence type is set as "rrule", which was not done in the module thus far. Whenever the rrule param was populated, the API would return a Bad Request with the response {'errors': ['Invalid recurrence type']}.

This change simply fixes this by adding the type when the param is present.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

datadog_downtime module

…am is present (#6811)

* added 'type' to recurrence object when rrule param is present

* formatting cleanup

(cherry picked from commit fc74f9a)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Jul 8, 2023
@felixfontein felixfontein merged commit 9ecfa37 into stable-6 Jul 8, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-6/fc74f9a4f20ae149b28518bc0992966e0ad7e915/pr-6811 branch July 8, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants